> On 2010-10-10 20:01:17, Ali Saidi wrote: > > src/mem/request.hh, line 75 > > <http://reviews.m5sim.org/r/269/diff/1/?file=4080#file4080line75> > > > > How about something more like CLEAR_LL or CLEAR_LLSC
Oh yeah, you're right. This is to clear the LLSC type of lock from Alpha, not the read-modify-write type of lock from X86. I guess I just had x86 stuck in my head. I like CLEAR_LL better since it's undoing that. The SC hasn't happened yet so it shouldn't be in the name. Barring any other suggestions or complaints I'll change it to that and commit it sometime soon. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/269/#review368 ----------------------------------------------------------- On 2010-10-09 15:34:37, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/269/ > ----------------------------------------------------------- > > (Updated 2010-10-09 15:34:37) > > > Review request for Default. > > > Summary > ------- > > Mem: Change the CLREX flag to CLEAR_LOCK. > > CLREX is the name of an ARM instruction, not a name for this generic flag. > > > Diffs > ----- > > src/arch/arm/isa/insts/misc.isa fde051006c8c > src/arch/arm/isa/templates/misc.isa fde051006c8c > src/arch/arm/tlb.cc fde051006c8c > src/mem/cache/cache_impl.hh fde051006c8c > src/mem/request.hh fde051006c8c > > Diff: http://reviews.m5sim.org/r/269/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
