----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/259/#review382 -----------------------------------------------------------
I realize these names predate this patch, but your changes make it evident that cachedSize and cachedStart are actually kind of dumb names, so this might be a good time to fix that. Since these are really just member variables that have accessors, shouldn't they be named _size and _start? - Steve On 2010-10-02 19:20:05, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/259/ > ----------------------------------------------------------- > > (Updated 2010-10-02 19:20:05) > > > Review request for Default. > > > Summary > ------- > > Mem: Finish half-baked support for mmaping file in physmem. > > Physmem has a parameter to be able to mem map a file, however > it isn't actually used. This changeset utilizes the parameter > so a file can be mmapped. > > > Diffs > ----- > > configs/common/FSConfig.py e78b6bba67ca > src/mem/physical.cc e78b6bba67ca > > Diff: http://reviews.m5sim.org/r/259/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
