> On 2010-10-17 21:29:17, Nathan Binkert wrote: > > I personally don't think you need to submit diffs for stuff like this.
I did for two reasons. 1. My experience with reviews at VMware was that everything, no matter how stupid, got reviewed, so that's my instinct. I realize the overhead is probably not warranted here, so I'll try to set a higher bar as far as review-worthiness. 2. Since this was an MIPS change, I wanted to give Korey a chance to object. I'll assume, unless Korey lets me know otherwise, that MIPS changes that don't break the regressions and that I have good faith belief don't break anything else can just go in. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/276/#review393 ----------------------------------------------------------- On 2010-10-16 14:55:50, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/276/ > ----------------------------------------------------------- > > (Updated 2010-10-16 14:55:50) > > > Review request for Default. > > > Summary > ------- > > MIPS: Get rid of the backdoor device copy/pasted from and only used in Alpha. > > > Diffs > ----- > > src/dev/mips/Malta.py addb847910d2 > src/dev/mips/MipsBackdoor.py addb847910d2 > src/dev/mips/SConscript addb847910d2 > src/dev/mips/backdoor.hh addb847910d2 > src/dev/mips/backdoor.cc addb847910d2 > > Diff: http://reviews.m5sim.org/r/276/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
