----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/278/#review407 -----------------------------------------------------------
Ship it! As long as what you say is true about it no longer being used, seems reasonable to me. - Nathan On 2010-10-22 17:36:04, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/278/ > ----------------------------------------------------------- > > (Updated 2010-10-22 17:36:04) > > > Review request for Default. > > > Summary > ------- > > Configs: Stop setting the "mem" parameter in splash2 config files. > > This parameter is no longer used, and trying to set it like these scripts were > gives a simobject two parents and causes the simulation to die. > > > Diffs > ----- > > configs/splash2/cluster.py fc12f4d657f0 > configs/splash2/run.py fc12f4d657f0 > > Diff: http://reviews.m5sim.org/r/278/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
