On 11/06/10 17:12, Gabe Black wrote:
>  On 11/06/10 15:56, Gabe Black wrote:
>>  On 11/05/10 18:06, nathan binkert wrote:
>>>> Might be good to download a scons-local 0.98.1 and verify this works, but 
>>>> otherwise I'm happy.
>>> I suggest that you do that.  Remember the last time I had that swig
>>> problem?  These programs sometimes lie about what their version
>>> supports.
>>>
>>>   Nate
>>> _______________________________________________
>>> m5-dev mailing list
>>> [email protected]
>>> http://m5sim.org/mailman/listinfo/m5-dev
>> I actually considered this sort of thing briefly back in the day. Maybe
>> it would be a good idea to have functionality tests but also more in
>> depth build tests. The functionality tests could run with m5.opt,
>> getting the asserts and whatnot in play since I think we're using
>> m5.fast in the regressions, and then the build tests could build all the
>> variants, try extreme versions of the tools like 0.98.1, etc., but just
>> make sure it builds and not that it runs. Maybe for components where
>> versions might matter at runtime like the python interpreter we could
>> have a simple test (hello world would be great) as a sanity check. Since
>> the functionality parts take a long, long time, we could verify this
>> other stuff pretty thoroughly and not affect the total runtime much.
>>
>> Of course, having multiple versions of tools around, selecting between
>> them, etc., would be a pain in the butt I think, and I'm certainly not
>> volunteering to do this myself at the moment, but it sounds nice.
>>
>> Gabe
>> _______________________________________________
>> m5-dev mailing list
>> [email protected]
>> http://m5sim.org/mailman/listinfo/m5-dev
> My change seems to work, but in the process of wedging that old a
> version of scons onto my system (no portage support, no download, had to
> get it from svn, had to manually "install" it). It looks like there are
> a few places where
>
>     main.Append(CCFLAGS='-pipe')
>
> is incorrectly interpreted as adding an array of flags "-", "p", "i",
> "p", "e", to CCFLAGS. This makes scons choke because it can't compile
> it's test programs to configure itself and gets confused trying to find
> Python.h. This is apparently not a problem with new versions of scons,
> and we inconsistently deal with the problem by sometimes putting []s
> around strings and sometimes not.
>
> I don't know for sure if this is an issue with my "installation" method,
> aka a big hammer and a callous disregard for how it's -supposed- to
> work, but if nothing else we should be consistent with how we stick []s
> in there.
>
> Gabe
> _______________________________________________
> m5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/m5-dev

For reference, the attached patch is what I used to get it to run
build/ALPHA_SE/tests/opt/quick with EXTRAS set to the eio stuff. I think
it's probably correct though it may not be complete.

Gabe
scons: Work around for old versions of scons mistaking strings for sequences.


diff -r 0d48ab0470fb -r 6c2e5178dce0 SConstruct
--- a/SConstruct        Fri Nov 05 11:06:51 2010 -0700
+++ b/SConstruct        Sat Nov 06 17:13:58 2010 -0700
@@ -357,10 +357,10 @@
 
 # Set up default C++ compiler flags
 if main['GCC']:
-    main.Append(CCFLAGS='-pipe')
-    main.Append(CCFLAGS='-fno-strict-aliasing')
+    main.Append(CCFLAGS=['-pipe'])
+    main.Append(CCFLAGS=['-fno-strict-aliasing'])
     main.Append(CCFLAGS=['-Wall', '-Wno-sign-compare', '-Wundef'])
-    main.Append(CXXFLAGS='-Wno-deprecated')
+    main.Append(CXXFLAGS=['-Wno-deprecated'])
     # Read the GCC version to check for versions with bugs
     # Note CCVERSION doesn't work here because it is run with the CC
     # before we override it from the command line
diff -r 0d48ab0470fb -r 6c2e5178dce0 ext/libelf/SConscript
--- a/ext/libelf/SConscript     Fri Nov 05 11:06:51 2010 -0700
+++ b/ext/libelf/SConscript     Sat Nov 06 17:13:58 2010 -0700
@@ -106,7 +106,7 @@
          "Please install M4 and try again."
    Exit(1)
 
-m4env.Append(M4FLAGS='-DSRCDIR=%s' % Dir('.').path)
+m4env.Append(M4FLAGS=['-DSRCDIR=%s' % Dir('.').path])
 m4env['M4COM'] = '$M4 $M4FLAGS $SOURCES > $TARGET'
 m4env.M4(target=File('libelf_convert.c'),
          source=[File('elf_types.m4'), File('libelf_convert.m4')])
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to