> On 2010-11-08 17:56:14, Nathan Binkert wrote: > > src/dev/ide_ctrl.cc, line 454 > > <http://reviews.m5sim.org/r/292/diff/1/?file=5058#file5058line454> > > > > Is this something that we should deal with on a per device basis, or is > > this a more generic thing? Also, is this something that should be > > configured by the user, or is this something that's either fixed or gleaned > > from the OS?
It seems rather arbitrary, but the world of function pointers that sets this value in the OS is pretty deep. I think having the user configure it is fine, there isn't a really good way we could grab it from the OS since there isn't once place where there is a device struct that describes a ide controller. These values only seem to apply to the IDE device. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/292/#review436 ----------------------------------------------------------- On 2010-11-08 15:34:45, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/292/ > ----------------------------------------------------------- > > (Updated 2010-11-08 15:34:45) > > > Review request for Default. > > > Summary > ------- > > ARM: Add support for a dumb IDE controller > > > Diffs > ----- > > configs/common/FSConfig.py f61e079ad05e > src/dev/Ide.py f61e079ad05e > src/dev/arm/realview.cc f61e079ad05e > src/dev/ide_ctrl.hh f61e079ad05e > src/dev/ide_ctrl.cc f61e079ad05e > src/dev/pcidev.cc f61e079ad05e > > Diff: http://reviews.m5sim.org/r/292/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
