----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/282/#review488 -----------------------------------------------------------
Ship it! Works for me if it works for you. A slightly longer discussion in the commit message about why Ctrl_Base_DepTag is better than FP_Bsae_DepTag + NumIntRegs would be nice though. Also just to be pedantic you could separate out the changes that are just line breaks, but this is small enough that I won't object. - Steve On 2010-10-31 14:32:57, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/282/ > ----------------------------------------------------------- > > (Updated 2010-10-31 14:32:57) > > > Review request for Default. > > > Summary > ------- > > O3: Fix fp destination register flattening, and index offset adjusting. > > > Diffs > ----- > > src/cpu/o3/rename_impl.hh 9d60c5339ae5 > > Diff: http://reviews.m5sim.org/r/282/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
