So, is everybody ok with these changes now, including the ISA specific ones? I'd like to get this generic part checked in and then start walking through the ISAs testing and submitting them one at a time. I'll leave the ARM one for last since that will, as usual, need some external verification.
Gabe Steve Reinhardt wrote: > Nice! I just skimmed the code quickly, but it looks good to me. > > Steve > > On Mon, Nov 15, 2010 at 4:35 AM, Gabe Black <[email protected] > <mailto:[email protected]>> wrote: > > This change implements the ISA parser part of new syntax to read and > write components of the PCState more like the old syntax. Things > center > around the PCState operand type, it's default ctype, and its register > index. When manipulating the PC state object as a whole, the ctype is > set to None and automatically becomes "TheISA::PCState", and the index > is also set to None. When dealing with components, ctype describes the > type for the extracted component and the register index specifier is > used as the name of the accessor function. > > The six subsequent patches update each of the ISAs to use the new > syntax. These could use more testing, as usual especially ARM, but I > wanted to get them out there before I started traveling. > > Gabe > > Gabe Black wrote: > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.m5sim.org/r/306/ > > > > > > Review request for Default. > > By Gabe Black. > > > > > > Description > > > > ISA: Get the parser to support pc state components more elegantly. > > > > > > Diffs > > > > * src/arch/isa_parser.py (f440cdaf1c2d) > > > > View Diff <http://reviews.m5sim.org/r/306/diff/> > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > m5-dev mailing list > > [email protected] <mailto:[email protected]> > > http://m5sim.org/mailman/listinfo/m5-dev > > > > _______________________________________________ > m5-dev mailing list > [email protected] <mailto:[email protected]> > http://m5sim.org/mailman/listinfo/m5-dev > > > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
