> On 2010-11-20 23:59:01, Gabe Black wrote:
> > src/cpu/base.cc, line 363
> > <http://reviews.m5sim.org/r/318/diff/1/?file=5376#file5376line363>
> >
> >     I like how this seems pretty general purpose and things shouldn't get 
> > lost in the shuffle this way (I think) but it would be nice if it didn't 
> > assume there was only one port that needed to be moved. Off hand I don't 
> > have any suggestion to fix it that wouldn't be overly cumbersome.

I'm assuming we'll cross that bridge when we come to it and i'll commit this in 
the mean time.


- Ali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/318/#review497
-----------------------------------------------------------


On 2010-11-19 16:11:58, Ali Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/318/
> -----------------------------------------------------------
> 
> (Updated 2010-11-19 16:11:58)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> ARM: Support switchover with hardware table walkers
> 
> 
> Diffs
> -----
> 
>   src/arch/arm/table_walker.cc 6286bb50127e 
>   src/arch/arm/tlb.hh 6286bb50127e 
>   src/arch/arm/tlb.cc 6286bb50127e 
>   src/cpu/base.cc 6286bb50127e 
>   src/sim/tlb.hh 6286bb50127e 
> 
> Diff: http://reviews.m5sim.org/r/318/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ali
> 
>

_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to