----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/340/#review520 -----------------------------------------------------------
src/cpu/o3/fetch.hh <http://reviews.m5sim.org/r/340/#comment767> Neither the tid or _mem_req seems to be used. These can get nuked, right? src/cpu/o3/fetch.hh <http://reviews.m5sim.org/r/340/#comment768> It's not necessary, but maybe an assert here that the "mode" parameter indicates a fetch? src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment769> Why should this be removed? src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment770> It's not part of your change, but while you're dicing up this function lets get rid of this commented out code. src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment771> This looks more involved than the original version of the code below. Why does it need to do more work? src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment772> star->start src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment773> Ah... This is why that block of code above can be removed? src/cpu/o3/fetch_impl.hh <http://reviews.m5sim.org/r/340/#comment774> This if and the one above it really are begging to be merged. If the condition turns into a big mess then never mind, but otherwise I think we definitely want to do that. - Gabe On 2010-12-06 16:11:45, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/340/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:11:45) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Support timing translations for O3 CPU fetch. > > > Diffs > ----- > > src/cpu/o3/fetch.hh 2b5fbdcbfb5d > src/cpu/o3/fetch_impl.hh 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/340/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
