> On 2010-12-21 10:46:35, Ali Saidi wrote: > > This really needs some documentation about which flags have been used, > > where they can be used and how you modify the build env by using them. > > > > Ali
Good point. Will do. > On 2010-12-21 10:46:35, Ali Saidi wrote: > > src/sim/SConscript, line 42 > > <http://reviews.m5sim.org/r/353/diff/1/?file=5798#file5798line42> > > > > typo? skip_lib maybe? Yes, this is a typo. It was already fixed in my patch, but for whatever reason, I didn't manage to get that up on reviewboard. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/353/#review547 ----------------------------------------------------------- On 2010-12-21 08:25:38, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/353/ > ----------------------------------------------------------- > > (Updated 2010-12-21 08:25:38) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > scons: make a flexible system for guarding source files > This is similar to guards on mercurial queues and they're used for selecting > which files are compiled into some given object. We already do something > similar, but it's mostly hard coded for the m5 binary and the m5 library > and I'd like to make it more flexible to better support the unittests > > > Diffs > ----- > > src/SConscript 4a3bddd74f36 > src/sim/SConscript 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/353/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
