-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/356/#review551
-----------------------------------------------------------

Ship it!


Looks good.. I would just like some more comments.


src/SConscript
<http://reviews.m5sim.org/r/356/#comment803>

    Comment on how to use it would be great!



src/unittest/SConscript
<http://reviews.m5sim.org/r/356/#comment804>

    How are these run/built?



src/unittest/stattestmain.py
<http://reviews.m5sim.org/r/356/#comment805>

    How does this end up in the m5 namespace for python?


- Ali


On 2010-12-21 08:27:29, Nathan Binkert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/356/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 08:27:29)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> -------
> 
> unittest: Make unit tests capable of using swig and python, convert stattest
> 
> 
> Diffs
> -----
> 
>   src/SConscript 4a3bddd74f36 
>   src/unittest/SConscript 4a3bddd74f36 
>   src/unittest/stattest.cc 4a3bddd74f36 
>   src/unittest/stattest.i PRE-CREATION 
>   src/unittest/stattestmain.py PRE-CREATION 
> 
> Diff: http://reviews.m5sim.org/r/356/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nathan
> 
>

_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to