----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/351/#review563 -----------------------------------------------------------
src/base/debug.hh <http://reviews.m5sim.org/r/351/#comment815> It looks like we're not completely consistent on this, but I'd put the close brace in column 0, then put the comment after that, e.g.: } // namespace Debug I don't care much about C vs C++-style comments, but having the brace in column 0 seems much more natural since that's where it would be if we weren't commenting it. Other than that nit (which applies several places), this looks good to me. - Steve On 2010-12-21 08:25:03, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/351/ > ----------------------------------------------------------- > > (Updated 2010-12-21 08:25:03) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > debug: create a Debug namespace > > > Diffs > ----- > > src/arch/alpha/ev5.cc 4a3bddd74f36 > src/base/debug.hh 4a3bddd74f36 > src/base/debug.cc 4a3bddd74f36 > src/base/statistics.cc 4a3bddd74f36 > src/cpu/pc_event.cc 4a3bddd74f36 > src/dev/ns_gige.cc 4a3bddd74f36 > src/dev/sinic.cc 4a3bddd74f36 > src/sim/debug.cc 4a3bddd74f36 > src/sim/pseudo_inst.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/351/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
