> On 2010-12-22 18:23:20, Nathan Binkert wrote: > > I only looked at a few. I hope that you don't expect anyone to read them > > all. Anyway, did you have any worthwhile regexes to put in the commit > > message? > > Steve Reinhardt wrote: > You only need to read them all if you want to retain your right to > complain about the result...
I just realized that you didn't do anything in SCons files, .py files, .sm files, or .i files. There's a lot of generated code out there :) - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/360/#review574 ----------------------------------------------------------- On 2010-12-22 17:39:40, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/360/ > ----------------------------------------------------------- > > (Updated 2010-12-22 17:39:40) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Make commenting on close namespace brackets consistent. > > > Diffs > ----- > > src/dev/sinic.hh 42f343470ee3 > src/dev/sinic.cc 42f343470ee3 > src/dev/sinicreg.hh 42f343470ee3 > src/dev/x86/cmos.hh 42f343470ee3 > src/dev/x86/i8042.hh 42f343470ee3 > src/dev/x86/i82094aa.hh 42f343470ee3 > src/dev/x86/i8237.hh 42f343470ee3 > src/dev/x86/i8254.hh 42f343470ee3 > src/dev/x86/i8259.hh 42f343470ee3 > src/dev/x86/intdev.hh 42f343470ee3 > src/dev/x86/speaker.hh 42f343470ee3 > src/kern/kernel_stats.hh 42f343470ee3 > src/kern/kernel_stats.cc 42f343470ee3 > src/mem/ruby/common/Address.hh 42f343470ee3 > src/sim/core.hh 42f343470ee3 > src/sim/core.cc 42f343470ee3 > src/sim/insttracer.hh 42f343470ee3 > src/sim/pseudo_inst.hh 42f343470ee3 > src/sim/pseudo_inst.cc 42f343470ee3 > src/sim/stat_control.hh 42f343470ee3 > src/sim/stat_control.cc 42f343470ee3 > src/base/trace.hh 42f343470ee3 > src/base/trace.cc 42f343470ee3 > src/base/varargs.hh 42f343470ee3 > src/cpu/exetrace.hh 42f343470ee3 > src/cpu/exetrace.cc 42f343470ee3 > src/cpu/inorder/inorder_trace.hh 42f343470ee3 > src/cpu/inorder/inorder_trace.cc 42f343470ee3 > src/cpu/inteltrace.hh 42f343470ee3 > src/cpu/inteltrace.cc 42f343470ee3 > src/cpu/legiontrace.hh 42f343470ee3 > src/cpu/legiontrace.cc 42f343470ee3 > src/cpu/nativetrace.hh 42f343470ee3 > src/cpu/nativetrace.cc 42f343470ee3 > src/dev/copy_engine_defs.hh 42f343470ee3 > src/dev/i8254xGBe_defs.hh 42f343470ee3 > src/arch/power/insts/integer.hh 42f343470ee3 > src/arch/power/insts/mem.hh 42f343470ee3 > src/arch/power/insts/misc.hh 42f343470ee3 > src/arch/power/insts/static_inst.hh 42f343470ee3 > src/arch/power/isa.hh 42f343470ee3 > src/arch/power/isa_traits.hh 42f343470ee3 > src/arch/power/locked_mem.hh 42f343470ee3 > src/arch/power/microcode_rom.hh 42f343470ee3 > src/arch/power/miscregs.hh 42f343470ee3 > src/arch/power/mmaped_ipr.hh 42f343470ee3 > src/arch/power/pagetable.hh 42f343470ee3 > src/arch/power/pagetable.cc 42f343470ee3 > src/arch/power/predecoder.hh 42f343470ee3 > src/arch/power/registers.hh 42f343470ee3 > src/arch/power/remote_gdb.hh 42f343470ee3 > src/arch/power/stacktrace.hh 42f343470ee3 > src/arch/power/tlb.hh 42f343470ee3 > src/arch/power/types.hh 42f343470ee3 > src/arch/power/utility.hh 42f343470ee3 > src/arch/power/utility.cc 42f343470ee3 > src/arch/power/vtophys.hh 42f343470ee3 > src/arch/sparc/faults.hh 42f343470ee3 > src/arch/sparc/kernel_stats.hh 42f343470ee3 > src/arch/sparc/nativetrace.hh 42f343470ee3 > src/arch/sparc/nativetrace.cc 42f343470ee3 > src/arch/sparc/tlb.cc 42f343470ee3 > src/arch/sparc/vtophys.cc 42f343470ee3 > src/arch/x86/cpuid.cc 42f343470ee3 > src/arch/x86/nativetrace.hh 42f343470ee3 > src/arch/x86/nativetrace.cc 42f343470ee3 > src/arch/x86/registers.hh 42f343470ee3 > src/arch/x86/tlb.cc 42f343470ee3 > src/arch/x86/utility.cc 42f343470ee3 > src/base/cprintf.hh 42f343470ee3 > src/base/cprintf.cc 42f343470ee3 > src/base/hashmap.hh 42f343470ee3 > src/base/inet.hh 42f343470ee3 > src/base/inet.cc 42f343470ee3 > src/base/mysql.hh 42f343470ee3 > src/base/mysql.cc 42f343470ee3 > src/base/statistics.hh 42f343470ee3 > src/base/statistics.cc 42f343470ee3 > src/base/stats/info.hh 42f343470ee3 > src/base/stats/mysql.hh 42f343470ee3 > src/base/stats/mysql.cc 42f343470ee3 > src/base/stats/mysql_run.hh 42f343470ee3 > src/base/stats/output.hh 42f343470ee3 > src/base/stats/output.cc 42f343470ee3 > src/base/stats/text.hh 42f343470ee3 > src/base/stats/text.cc 42f343470ee3 > src/base/stats/types.hh 42f343470ee3 > src/base/stats/visit.hh 42f343470ee3 > src/base/stats/visit.cc 42f343470ee3 > src/base/stl_helpers.hh 42f343470ee3 > src/arch/arm/nativetrace.cc 42f343470ee3 > src/arch/arm/tlb.hh 42f343470ee3 > src/arch/mips/dsp.hh 42f343470ee3 > src/arch/mips/faults.hh 42f343470ee3 > src/arch/mips/isa_traits.hh 42f343470ee3 > src/arch/mips/kernel_stats.hh 42f343470ee3 > src/arch/mips/linux/threadinfo.hh 42f343470ee3 > src/arch/power/faults.hh 42f343470ee3 > src/arch/power/insts/branch.hh 42f343470ee3 > src/arch/power/insts/condition.hh 42f343470ee3 > src/arch/power/insts/floating.hh 42f343470ee3 > src/arch/alpha/mt.hh 42f343470ee3 > src/arch/alpha/pagetable.cc 42f343470ee3 > src/arch/alpha/tlb.cc 42f343470ee3 > src/arch/arm/faults.hh 42f343470ee3 > src/arch/arm/isa_traits.hh 42f343470ee3 > src/arch/arm/kernel_stats.hh 42f343470ee3 > src/arch/arm/nativetrace.hh 42f343470ee3 > > Diff: http://reviews.m5sim.org/r/360/diff > > > Testing > ------- > > still compiles > > > Thanks, > > Steve > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
