> On 2010-12-25 20:10:03, Nathan Binkert wrote: > > One big question I have is, do people like the sorting order. This went > > along with what Steve had in his wish list for the perl version, but it > > isn't as simple as M-x sort-lines anymore. Of course, people could run > > this on their code. I could even plug it into the style hook.
One other question is, should we separate out automatically generated headers? (like those for params and soon, debug flags?) If so, should I rename them at all, put them in a subdirectory (generated/params/Foo.hh), or leave them alone? Given that there is going to be a bunch of churn, we may as well do it all at once. I'll try to add the sorting function to the style hook, but that will be later. I probably need to do a bit of work to make the commit hook work better for some people anyway. Do people have it enabled generally? - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/362/#review579 ----------------------------------------------------------- On 2010-12-25 20:05:55, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/362/ > ----------------------------------------------------------- > > (Updated 2010-12-25 20:05:55) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > util: python implementation of a routine that will sort includes > I didn't realize that the perl version existed when I started this, > this version has a lot more features than the previous one since it will > sort and separate python, system, and m5 headers in separate groups, it > will remove duplicates, it will also convert c headers to stl headers > > > Diffs > ----- > > util/file_types.py PRE-CREATION > util/sort-includes f249937228b5 > util/sort_includes.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/362/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
