> On 2011-01-07 05:51:30, Gabe Black wrote: > > src/arch/x86/pagetable_walker.cc, line 77 > > <http://reviews.m5sim.org/r/396/diff/1/?file=9103#file9103line77> > > > > These should use FastAlloc if at all possible since they're on a > > critical path and the heap is slow. > > Joel Hestness wrote: > Is this as simple as having WalkerState inherit from FastAlloc?
Yes I think so. I've never used FastAlloc myself, but it looks like it basically allocates a big pool of memory in certain sized chunks, and then rather than allocating them on the heap it just grabs a free one and fills it in. That implies your class has to be a fixed size or less (512 bytes according to the header). If it's too big then "new" falls back to the heap, so it'd actually be a little slower than going to the heap directly. Packets use FastAlloc if you want an example. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/396/#review649 ----------------------------------------------------------- On 2011-01-06 16:12:34, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/396/ > ----------------------------------------------------------- > > (Updated 2011-01-06 16:12:34) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > x86: Timing support for pagetable walker > > Move page table walker state to its own object type, and make the > walker instantiate state for each outstanding walk. By storing the > states in a queue, the walker is able to handle multiple outstanding > timing requests. Note that functional walks use separate state > elements. > > > Diffs > ----- > > src/arch/x86/pagetable_walker.hh 9f9e10967912 > src/arch/x86/pagetable_walker.cc 9f9e10967912 > src/arch/x86/tlb.hh 9f9e10967912 > src/arch/x86/tlb.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/396/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
