> diff -r e49c7db3ac53 -r c06505ff551e src/sim/root.cc > --- a/src/sim/root.cc Mon Jan 10 04:53:20 2011 -0800 > +++ b/src/sim/root.cc Mon Jan 10 04:53:34 2011 -0800 > @@ -29,12 +29,6 @@ > * Steve Reinhardt > */ > > -#include <cstring> > -#include <fstream> > -#include <list> > -#include <string> > -#include <vector> > -
My biggest question about a change like this is, did you create any false dependencies? If any of these headers are used below, then they should, in general, remain in case an include is removed. All that said, they can of course be added back if needed in the future. This sort of thing makes me think that perhaps it would be a good idea for us to implement the trick that's in the google style guide. Nate _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
