----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/420/#review721 -----------------------------------------------------------
After you delete the commented out lines, please check it in. I was leery of silently dropping those L1_PUTXes and I'm glad to see the L2 no longer does that. src/mem/protocol/MESI_CMP_directory-L2cache.sm <http://reviews.m5sim.org/r/420/#comment988> Please delete these commented out lines - Brad On 2011-01-10 11:48:16, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/420/ > ----------------------------------------------------------- > > (Updated 2011-01-10 11:48:16) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Ruby: Fixes MESI CMP directory protocol > The current implementation of MESI CMP directory protocol is broken. > This patch, from Arkaprava Basu, fixes the protocol. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-L1cache.sm c06505ff551e > src/mem/protocol/MESI_CMP_directory-L2cache.sm c06505ff551e > > Diff: http://reviews.m5sim.org/r/420/diff > > > Testing > ------- > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
