> On 2011-01-13 08:48:29, Brad Beckmann wrote: > > src/mem/protocol/MOESI_CMP_directory-L1cache.sm, line 159 > > <http://reviews.m5sim.org/r/359/diff/8/?file=9537#file9537line159> > > > > So the assumption here is the L1IcacheMemory.lookup() call either > > returns the L1I cache entry or NULL/OOD, correct? Does SLICC also support > > explicitly passing back OOD?
Currently, SLICC does not have support for Out Of Domain (OOD) token. But I can add that as I had done earlier. I am not sure if we actually need it. > On 2011-01-13 08:48:29, Brad Beckmann wrote: > > src/mem/protocol/MOESI_CMP_directory-L1cache.sm, line 465 > > <http://reviews.m5sim.org/r/359/diff/8/?file=9537#file9537line465> > > > > This seems like an unrelated change, correct. However it is pretty > > minor, so don't worry about it. IIRC, this is necessary or else a certain panic state is reached. I think I should separately make this change. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/359/#review728 ----------------------------------------------------------- On 2011-01-12 22:44:50, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/359/ > ----------------------------------------------------------- > > (Updated 2011-01-12 22:44:50) > > > Review request for Default. > > > Summary > ------- > > This is a request for reviewing the proposed changes to the MOESI CMP > directory cache coherence protocol to make it conform with the new cache > memory interface and changes to SLICC. > > > Diffs > ----- > > src/mem/protocol/MOESI_CMP_directory-L1cache.sm c6bc8fe81e79 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm c6bc8fe81e79 > src/mem/protocol/MOESI_CMP_directory-dir.sm c6bc8fe81e79 > src/mem/protocol/MOESI_CMP_directory-dma.sm c6bc8fe81e79 > > Diff: http://reviews.m5sim.org/r/359/diff > > > Testing > ------- > > These changes have been tested using the Ruby random tester. The tester was > used with -l = 1048576 and -n = 2. > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
