----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/437/#review802 -----------------------------------------------------------
i don't know that you can comment multiple functions with a singel doxygen comment src/base/refcnt.hh <http://reviews.m5sim.org/r/437/#comment1124> This should include a description of what the file does. You don't need the file name if you dont want to have it. - Ali On 2011-01-24 17:07:56, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/437/ > ----------------------------------------------------------- > > (Updated 2011-01-24 17:07:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > refcnt: Update doxygen comments > > I've added doxygen comments. One question: How do I make one comment apply > for multiple functions? I don't think I did that right. > > Second comment, the refcounting pointer code doesn't actually allow you to > compare/cast pointers of two different types very easily. Should we fix it? > Have people run into this problem? > > > Diffs > ----- > > src/base/refcnt.hh 31a04e5ac4be > > Diff: http://reviews.m5sim.org/r/437/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
