> On 2011-01-25 09:50:24, Nathan Binkert wrote: > > src/mem/ruby/storebuffer/storebuffer.cc, line 94 > > <http://reviews.m5sim.org/r/439/diff/1/?file=10073#file10073line94> > > > > Is this right? My guess is that the entire "if (!m_use_storebuffer) { > > }" block should be replaced by an "if (!m_use_storebuffer) fatal("must > > provide a storebuffer in the configuration")" or something like this. I > > don't see how this could work without a storebuffer.
Even I was surprised when I saw this. May be we should drop m_use_storebuffer all together. Since libruby was not performing any function, dropping m_use_storebuffer should not affect the functionality at all. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/439/#review801 ----------------------------------------------------------- On 2011-01-25 09:25:35, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/439/ > ----------------------------------------------------------- > > (Updated 2011-01-25 09:25:35) > > > Review request for Default. > > > Summary > ------- > > This patch removes libruby. It was already broken and is no longer required > as noted by Derek in another thread. There are still several files that > include libruby.hh, but I am not sure how to compile those. > > src/mem/ruby/tester/DeterministicDriver.cc > src/mem/ruby/tester/RaceyPseudoThread.hh > src/mem/ruby/tester/test_framework.cc > src/mem/ruby/tester/RaceyDriver.hh > src/mem/ruby/tester/DeterministicDriver.hh > src/mem/ruby/tester/RaceyDriver.cc > src/mem/ruby/tester/RaceyPseudoThread.cc > > > Diffs > ----- > > src/mem/ruby/libruby.cc 31a04e5ac4be > src/mem/ruby/libruby.hh 31a04e5ac4be > src/mem/ruby/SConscript 31a04e5ac4be > src/mem/ruby/profiler/Profiler.hh 31a04e5ac4be > src/mem/ruby/storebuffer/storebuffer.hh 31a04e5ac4be > src/mem/ruby/storebuffer/storebuffer.cc 31a04e5ac4be > src/mem/ruby/system/Sequencer.cc 31a04e5ac4be > > Diff: http://reviews.m5sim.org/r/439/diff > > > Testing > ------- > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
