Insane probably not, but it is a bit confusing. How about renaming sim/fault.hh to sim/faulttype.hh?
Gabe nathan binkert wrote: > Does anyone else think that it's insane to have one file called > fault.hh and another called faults.hh? > > On Sat, Jan 29, 2011 at 7:34 PM, Gabe Black <gbl...@eecs.umich.edu> wrote: > >> The diff didn't change, just the description. I was hoping review board >> would see it was the same diff but it didn't. >> >> Gabe >> >> Gabe Black wrote: >> >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.m5sim.org/r/453/ >>> >>> >>> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, >>> and Nathan Binkert. >>> By Gabe Black. >>> >>> /Updated 2011-01-29 19:36:33.797798/ >>> >>> >>> Description (updated) >>> >>> Fault: Move the definition of NoFault from faults.hh to fault.hh. >>> >>> Moving the definition of NoFault into fault.hh doesn't bring any new >>> dependencies with it, and allows some files to include just fault.hh which >>> has >>> less baggage. NoFault will still be available to everything that includes >>> faults.hh because it includes fault.hh. >>> >>> >>> Diffs (updated) >>> >>> * src/sim/fault.hh (31a04e5ac4be) >>> * src/sim/faults.hh (31a04e5ac4be) >>> >>> View Diff <http://reviews.m5sim.org/r/453/diff/> >>> >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> m5-dev mailing list >>> m5-dev@m5sim.org >>> http://m5sim.org/mailman/listinfo/m5-dev >>> >>> >> _______________________________________________ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev >> >> >> > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
