Looks correct to me (though I'm not an ARM guy) Nate
On Sun, Feb 13, 2011 at 3:17 AM, Gabe Black <gbl...@eecs.umich.edu> wrote: > These are failing because of the following: > > cc1plus: warnings being treated as errors > build/SPARC_SE/cpu/o3/inst_queue_impl.hh: In member function 'void > InstructionQueue<Impl>::scheduleReadyInsts() [with Impl = O3CPUImpl]': > build/SPARC_SE/cpu/o3/inst_queue.cc:35: instantiated from here > build/SPARC_SE/cpu/o3/inst_queue_impl.h:751: warning: NULL used in > arithmetic > > This warning seems to be going on specifically on gcc 4.2.4 which is > what's on zizzer. The warning looks pretty bogus (it's a comparison, not > arithmetic) but there may be some weirdness coming from the fact that > there's a reference counting pointer in there. I'd say it's most likely > a compiler bug. In any case, this is being triggered by the recent > change to make O3 re-execute memory instructions whose translation has > been delayed, and the attached patch fixes it. This gets rid of the > assignment in the while condition (clever, but perhaps overly clever). > It evaluates the pointer directly instead of comparing it to NULL, and > that looks too much like it was meant to be a test for equality to leave > in the while condition. > > I would appreciate it if the ARM folks could please look this patch over > and make sure that code is still doing what you expected it to (it > should be functionally equivalent, but I'm being paranoid) and if so > commit it. > > Gabe > > On 02/13/11 00:50, Cron Daemon wrote: >> scons: *** [build/ALPHA_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ALPHA_SE_MOESI_hammer/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ALPHA_SE_MESI_CMP_directory/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ALPHA_SE_MOESI_CMP_directory/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ALPHA_SE_MOESI_CMP_token/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ALPHA_FS/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/MIPS_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/POWER_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/SPARC_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/X86_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ARM_SE/cpu/o3/inst_queue.fo] Error 1 >> scons: *** [build/ARM_FS/cpu/o3/inst_queue.fo] Error 1 >> ***** >> build/SPARC_FS/tests/fast/long/80.solaris-boot/sparc/solaris/t1000-simple-atomic >> passed. >> >> See /z/m5/regression/regress-2011-02-13-03:00:01 for details. >> >> _______________________________________________ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
