Brad, this patch to affects the number of ticks required
for performing a particular number of loads. I don't expect such a thing
to happen. Do you?
--
Nilay
On Wed, 9 Feb 2011, Brad Beckmann wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/328/#review839
-----------------------------------------------------------
Overall, this looks great. A pretty simple change that offers significant
speedup. I just have one question about the parameters to storeEventInfo.
src/mem/ruby/buffers/MessageBuffer.cc
<http://reviews.m5sim.org/r/328/#comment1196>
Is there a reason why you want to pass the message pointer instead of just
the vnet id?
src/mem/ruby/network/simple/PerfectSwitch.cc
<http://reviews.m5sim.org/r/328/#comment1197>
It seems that you could remove the safe_cast and message pointer dereference
if you passed in the vnet id as the first parameter. Am I missing something?
- Brad
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
