----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/ -----------------------------------------------------------
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary ------- ruby: naming for RubyNetwork dprintfs add a name() to the Ruby Throttle & PerfectSwitch objects so that the debug output isn't littered w/global: everywhere and it also negates the need to put the name of the object in every dprintf in the form of "DPRINTF(RubyNetwork, "Switch %i: <msg>"). This also makes debug output easier to read and conforms to how the other objects are handled in M5 for debugging ... Additionally, knock off an extra newline on a message buffer print Diffs ----- src/mem/ruby/buffers/MessageBuffer.cc 68a5b8bba293 src/mem/ruby/network/simple/PerfectSwitch.hh 68a5b8bba293 src/mem/ruby/network/simple/PerfectSwitch.cc 68a5b8bba293 src/mem/ruby/network/simple/Throttle.hh 68a5b8bba293 src/mem/ruby/network/simple/Throttle.cc 68a5b8bba293 Diff: http://reviews.m5sim.org/r/489/diff Testing ------- Thanks, Korey
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev