> On 2011-02-15 05:24:20, Steve Reinhardt wrote: > > configs/common/Options.py, line 41 > > <http://reviews.m5sim.org/r/485/diff/1/?file=10324#file10324line41> > > > > Did you intend to change this default value too? If so, why? > >
The default in CacheConfig.py was 64kB, but the default in Options.py was 32kB, so I figured since CacheConfig.py was hardcoding the config anyway, that the default parameters should match what the previous hardcoded values were. - Korey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/485/#review867 ----------------------------------------------------------- On 2011-02-13 19:13:33, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/485/ > ----------------------------------------------------------- > > (Updated 2011-02-13 19:13:33) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > configs: set default cache params > It's confusing (especially to new users), when you are setting some standard > parameters (as defined in Options.py) and they aren't reflected in the > simulations > so we might as well link the settings in CacheConfig.py to those in Options.py > > > Diffs > ----- > > configs/common/CacheConfig.py 68a5b8bba293 > configs/common/Options.py 68a5b8bba293 > > Diff: http://reviews.m5sim.org/r/485/diff > > > Testing > ------- > > > Thanks, > > Korey > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
