> On 2011-02-18 08:10:43, Korey Sewell wrote: > > Should the "remove of foo/goo queues" and the "adding of MachineType" be > > separate (albeit small) patches?
I'll commit them as separate patches. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/490/#review873 ----------------------------------------------------------- On 2011-02-18 06:01:20, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/490/ > ----------------------------------------------------------- > > (Updated 2011-02-18 06:01:20) > > > Review request for Default. > > > Summary > ------- > > Ruby: clean MOESI CMP directory protocol > The L1 cache controller file contains references to foo and goo queues, which > are not in use at all. These have been removed. In certain actions, while > creating an outgoing message, the machine type was not being set. This > results in a segmentation fault when trace is collected. Joseph Pusudesris > provided his patch for fixing this issue. > > > Diffs > ----- > > src/mem/protocol/MOESI_CMP_directory-L1cache.sm 96bde0910197 > > Diff: http://reviews.m5sim.org/r/490/diff > > > Testing > ------- > > Some very mild testing has been done using m5.debug and ruby random tester. > The > trace flag was set to Ruby. > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
