----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/497/#review888 -----------------------------------------------------------
Ship it! I'd like to see that change, but if you want to just get this in, I'm fine. configs/common/Benchmarks.py <http://reviews.m5sim.org/r/497/#comment1251> I'd like to actually see us not use "*". Is that painful? - Nathan On 2011-02-23 02:20:35, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/497/ > ----------------------------------------------------------- > > (Updated 2011-02-23 02:20:35) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Configs: Explicitly import env in Benchmarks.py > > env was being implicitly imported into Benchmarks.py through SysPaths.py. > This change brings it in explicitly in the file where it's used. > > > Diffs > ----- > > configs/common/Benchmarks.py 8fe2d7ff1111 > > Diff: http://reviews.m5sim.org/r/497/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
