> On 2011-02-26 16:48:07, Gabe Black wrote: > > I don't see anything obviously wrong here, although I'm sure it wouldn't be > > hard to slip a bug into this code accidentally. Please be sure to run all > > the regressions just in case.
They all run. I was very careful when I did it, so I believe it is correct. > On 2011-02-26 16:48:07, Gabe Black wrote: > > src/cpu/o3/comm.hh, line 200 > > <http://reviews.m5sim.org/r/510/diff/1/?file=10538#file10538line200> > > > > You have two sentences mushed together here. yup. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/510/#review908 ----------------------------------------------------------- On 2011-02-25 21:04:59, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/510/ > ----------------------------------------------------------- > > (Updated 2011-02-25 21:04:59) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Cleanup the commitInfo comm struct. > > Get rid of unused members and use base types rather than derrived values > where possible to limit amount of state. This cleans up a change to the > fetch stage I promised Steve a month ago. > > > Diffs > ----- > > src/cpu/o3/comm.hh 9dc17725f795 > src/cpu/o3/commit.hh 9dc17725f795 > src/cpu/o3/commit_impl.hh 9dc17725f795 > src/cpu/o3/fetch_impl.hh 9dc17725f795 > src/cpu/o3/iew_impl.hh 9dc17725f795 > > Diff: http://reviews.m5sim.org/r/510/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
