I'm fine with getting rid of it. For me it's been the source of problems, particularly with update_ref, and I haven't personally seen a benefit.
Steve On Wed, Mar 9, 2011 at 2:19 PM, Gabe Black <gbl...@eecs.umich.edu> wrote: > A while back I proposed we add the mercurial changeset to the binary so > that it could print it out as it started up. The idea was that if > somebody showed us some output where something was broken or we found a > random binary, we could tell what the underlying code was without having > to ask. > > Have people found that to be useful so far? I don't think I've ever > actually seen it in output somebody posted to m5-users in a way that > helped solve their problem. Often people don't paste in output at all, > or just include an error message. > > This change also had the unfortunate side effect of forcing scons to > rebuild the m5 binary every time a patch was pushed or popped even if > ultimately nothing changed. I'd like to determine if this mechanism has > been useful for anyone else, or if it's just a nice idea that didn't pan > out and is now only getting in the way. If it's the later, we should > probably get rid of it. > > Gabe > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
