Hi,

We've looked into the following piece of code in src/cpu/o3/inst_queue_impl.hh 
(http://repo.m5sim.org/m5/diff/7bb1223f9645/src/cpu/o3/inst_queue_impl.hh), it 
looks like the old assertion "assert(ns_inst_it != nonSpecInsts.end" should be 
removed when both cases are covered in the patch diff below.

    1.38                  assert(ns_inst_it != nonSpecInsts.end());
    1.39 +                if (ns_inst_it == nonSpecInsts.end()) {
    1.40 +                    assert(squashed_inst->getFault() != NoFault);
    1.41 +                } else {
    1.42

I'm curious why the assertion "assert(ns_inst_it != nonSpecInsts.end" is not 
removed. Repo.m5sim.org shows the change was committed by Kevin Lim.

Thanks,
William


-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium.  Thank you.

_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to