Gabe, thanks for putting this patch out for review. I had forgotten that this directory still exists. I moved the code that I'm most familiar with out of this directory last year, but I didn't touch the Racey tester code because I wasn't sure what to do with it. I believe that code was written by Min Xu several years ago to test his flight data recorder. Subsequently we used to use it for general testing because it tended to find certain bugs much faster than the standard random tester. That being said, I suspect that code hasn't been used in 5+ years and at some point we need to have a timeout and just delete it. Unless the folks at Wisconsin prefer otherwise, I'm completely fine with deleting the whole directory.
Regardless, the DeterministicDriver files should definitely be deleted. That functionality now exists in the directedtest directory. I should have deleted them in my changeset from last year. By the way, this reminds me that the directed test code is another piece that should be added to the regression tester. I'll add that to my list. Brad > -----Original Message----- > From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] > On Behalf Of Steve Reinhardt > Sent: Thursday, March 10, 2011 11:10 AM > To: Gabe Black > Cc: Default; Ali Saidi > Subject: Re: [m5-dev] Review Request: Ruby: Get rid of the dead ruby > tester. > > I don't think it's dead, just sleeping... I'm not sure why it's not compilable > right now (I thought it was usable), but I'd rather just fix that up than > whack > the code. We definitely need some input from Brad or the Wisconsin folks > before making this change. > > Steve > > On Thu, Mar 10, 2011 at 11:03 AM, Gabe Black <gbl...@eecs.umich.edu> > wrote: > > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.m5sim.org/r/555/ > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, > > and Nathan Binkert. > > By Gabe Black. > > Description > > > > Ruby: Get rid of the dead ruby tester. > > > > None of the code in the ruby tester directory is compiled or referred > > to outside of that directory. This change eliminates it. If it's > > needed in the future, it can be revived from the history. In the mean > > time, this removes clutter and the only use of the GEMS_ROOT scons > variable. > > > > Diffs > > > > - src/mem/ruby/tester/DeterministicDriver.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/DeterministicDriver.cc (77aa0f94e7f2) > > - src/mem/ruby/tester/RaceyDriver.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/RaceyDriver.cc (77aa0f94e7f2) > > - src/mem/ruby/tester/RaceyPseudoThread.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/RaceyPseudoThread.cc (77aa0f94e7f2) > > - src/mem/ruby/tester/SConscript (77aa0f94e7f2) > > - src/mem/ruby/tester/SpecifiedGenerator.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/SpecifiedGenerator.cc (77aa0f94e7f2) > > - src/mem/ruby/tester/Tester_Globals.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/main.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/main.cc (77aa0f94e7f2) > > - src/mem/ruby/tester/test_framework.hh (77aa0f94e7f2) > > - src/mem/ruby/tester/test_framework.cc (77aa0f94e7f2) > > > > View Diff <http://reviews.m5sim.org/r/555/diff/> > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
