> On 2011-03-18 18:30:07, Gabe Black wrote: > > configs/example/se.py, line 83 > > <http://reviews.m5sim.org/r/598/diff/1/?file=11044#file11044line83> > > > > Splitting on "," would be a little more standard.
True. I have a moderately good reason for this. When creating an aggregated checkpoint, the aggregate script makes cpt.b1-b2-b3.XXXXX. So, if you hand your argument over as --bench b1-b2-b3, no finagling is necessary to be able to find the appropriate checkpoint, it just takes the options.bench string and looks for it, exactly the same as a uniprocessor checkpoint restore situation. Splitting on commas would mean later overwriting the options.bench param to hand over to Simulation.py to find an aggregated checkpoint or doing some other such thing to make things understood. This just seemed easier, even if it is a little non-traditional. I'd prefer to keep it this way. - Lisa ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/598/#review993 ----------------------------------------------------------- On 2011-03-18 16:06:02, Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/598/ > ----------------------------------------------------------- > > (Updated 2011-03-18 16:06:02) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > se.py: Modify script to make multiprogramming much easier. > Now, instead of --bench benchname, you can do --bench bench1-bench2-bench3 > and it will > set up a simulation that instantiates those three workloads. Only caveat is > that now, > for sanity checking, your -n X must match the number of benches in the list. > > > Diffs > ----- > > configs/example/se.py b0ecadb07742 > > Diff: http://reviews.m5sim.org/r/598/diff > > > Testing > ------- > > > Thanks, > > Lisa > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
