----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/609/#review1019 -----------------------------------------------------------
src/arch/x86/bios/E820.py <http://reviews.m5sim.org/r/609/#comment1388> I think at least most of these lists should be allowed to be empty regardless of if they're being appended to. - Gabe On 2011-03-26 12:17:28, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/609/ > ----------------------------------------------------------- > > (Updated 2011-03-26 12:17:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > config: revamp x86 config to avoid appending to SimObjectVectors > A significant contributor to the need for adoptOrphanParams() > is the practice of appending to SimObjectVectors which have > already been assigned as children. This practice sidesteps the > assignment operation for those appended SimObjects, which is > where parent/child relationships are typically established. > > This patch reworks the config scripts that use append() on > SimObjectVectors, which all happen to be in the x86 system > configuration. At some point in the future, I hope to make > SimObjectVectors immutable (by deriving from tuple rather than > list), at which time this patch will be necessary for correct > operation. For now, it just avoids some of the warning > messages that get printed in adoptOrphanParams(). > > > Diffs > ----- > > configs/common/FSConfig.py d8587c913ccf > src/arch/x86/bios/E820.py d8587c913ccf > src/dev/x86/SouthBridge.py d8587c913ccf > > Diff: http://reviews.m5sim.org/r/609/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
