----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/617/#review1037 -----------------------------------------------------------
src/arch/arm/faults.cc <http://reviews.m5sim.org/r/617/#comment1408> The "Faults" trace flag can be useful during boot to see where things go haywire since early on there shouldn't be any, at least in ISAs with hardware TLB miss handlers. Perhaps you should make this and any other artificial faults use FaultsVerbose or similar so they get ignored unless you really wanted to see them. src/arch/arm/table_walker.cc <http://reviews.m5sim.org/r/617/#comment1406> It's not part of this change, but the brackets are messed up on this line. src/arch/arm/table_walker.cc <http://reviews.m5sim.org/r/617/#comment1407> This panic doesn't do anything any more. - Gabe On 2011-03-30 09:05:28, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/617/ > ----------------------------------------------------------- > > (Updated 2011-03-30 09:05:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Fix table walk going on while ASID changes error > > > Diffs > ----- > > src/arch/arm/faults.hh d54b7775a6b0 > src/arch/arm/faults.cc d54b7775a6b0 > src/arch/arm/table_walker.cc d54b7775a6b0 > src/arch/arm/tlb.cc d54b7775a6b0 > > Diff: http://reviews.m5sim.org/r/617/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
