> On 2011-03-31 15:58:14, Brad Beckmann wrote: > > src/mem/slicc/symbols/StateMachine.py, line 477 > > <http://reviews.m5sim.org/r/624/diff/1/?file=11400#file11400line477> > > > > Do you also need to declare the contains_dma_sequencer flag here and > > set it to False?
Brad, great catch - since contains_sequencer is no longer used at all, it should be s/contains_sequencer/contains_dma_sequencer/g. You pointing this out makes me realize that I have not compiled against FS at all, and I was using regression quick tests as my measuring stick. I'll add that fix and make sure the protocols compile under FS as well. This should be the only thing out of all the patches that has anything to do with FS|SE distinction though. - Lisa ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/624/#review1069 ----------------------------------------------------------- On 2011-03-31 12:20:53, Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/624/ > ----------------------------------------------------------- > > (Updated 2011-03-31 12:20:53) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Ruby: enable multiple sequencers in one controller. > > > Diffs > ----- > > src/mem/slicc/symbols/StateMachine.py d8587c913ccf > > Diff: http://reviews.m5sim.org/r/624/diff > > > Testing > ------- > > > Thanks, > > Lisa > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
