changeset 1c89a6d235b9 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=1c89a6d235b9
description:
        ARM: Get rid of some comments/todos that no longer apply.

diffstat:

 src/arch/arm/linux/process.cc |  5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diffs (22 lines):

diff -r 02cb69e5cfeb -r 1c89a6d235b9 src/arch/arm/linux/process.cc
--- a/src/arch/arm/linux/process.cc     Wed Apr 06 14:41:41 2011 -0700
+++ b/src/arch/arm/linux/process.cc     Sun Apr 10 21:02:28 2011 -0400
@@ -518,8 +518,6 @@
                                     swiNeg1, sizeof(swiNeg1));
     }
 
-    // We don't have barriers, so just return.
-    // @todo Add a barrrier in this code
     uint8_t memory_barrier[] =
     {
         0x5f, 0xf0, 0x7f, 0xf5, // dmb
@@ -528,9 +526,6 @@
     tc->getMemPort()->writeBlob(commPage + 0x0fa0, memory_barrier,
                                 sizeof(memory_barrier));
 
-    // This -should- be atomic, but I don't think all the support that we'd
-    // need is implemented. There should also be memory barriers around it.
-    // @todo replace this with ldrex/strex and dmb
     uint8_t cmpxchg[] =
     {
         0x9f, 0x3f, 0x92, 0xe1,  // ldrex    r3, [r2]
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to