----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1129 -----------------------------------------------------------
Ship it! Just a few minor alignment requests. Other than that, it looks good to me. src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1532> Since you're already modifying this DPRINTFR, can you align all the lines to the open paranethesis? Thanks src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1533> align here please src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/635/#comment1534> align here please - Brad On 2011-04-15 10:33:39, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/635/ > ----------------------------------------------------------- > > (Updated 2011-04-15 10:33:39) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: dbg: use system ticks instead of cycles > It's easier to debug simulations (find the exact point to rerun a trace) when > the output is in > the system ticks instead of the Ruby cycle time > > > Diffs > ----- > > src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 > src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 > src/mem/ruby/system/Sequencer.cc 54a65799e4c1 > src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 > src/mem/slicc/symbols/Type.py 54a65799e4c1 > > Diff: http://reviews.m5sim.org/r/635/diff > > > Testing > ------- > > > Thanks, > > Korey > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
