There's more to it than that. I started it yesterday and I'll post a diff today and you can see what I mean.
So one question to you Nate, is what do you prefer, doing a single #if FULL_SYSTEM in the C++, or doing a if buildEnv[FULL_SYSTEM] in the python so that the value passed into the C++ is already correct? Could probably be done in CacheConfig so that it's in a common place that people can't forget to do it. It's totally a stylistic question. Lisa On Tue, Apr 19, 2011 at 6:57 PM, nathan binkert <[email protected]> wrote: > > Yes, Steve's got it right. In the C++ you replace the instances of the 3 > > lengths Nate mentions with a single var (that can be more aptly named as > > Steve wants) that is pythonically calculated and passed in from the > > configuration. I'm making up words here :). > > > > I think I can do this tonight or tomorrow, I don't think it's that > > complicated, so yes, I'm healthy enough :). > > I just posted a review. I'm running tests right now. Let me know if > this is what you all had in mind please. > > http://reviews.m5sim.org/r/646/ > > Nate > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
