----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/649/#review1139 -----------------------------------------------------------
I like this change from a design perspective, and I didn't see anything obviously wrong with the code. I'll assume you've identified and fixed all possible bugs. :-) util/regress <http://reviews.m5sim.org/r/649/#comment1555> This hack may no longer be necessary. This is outside the scope of your change, but I thought I'd point it out while I'm thinking of it. - Gabe On 2011-04-20 22:42:16, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/649/ > ----------------------------------------------------------- > > (Updated 2011-04-20 22:42:16) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > util/regress: make default action a more thorough regression > > Changed the --variants option to --test-variants and added a new > --compile-variants option for variants that are only compiled > (not tested). The former still defaults to 'opt' and the latter > defaults to 'debug,fast'. > > Also changed the behavior when no tests are specified from just > compiling to running the 'quick' tests. > > As a result, a plain 'util/regress' invocation will now compile > (but not test) the debug and fast builds, and compile and run the > quick regressions on the opt build. This should be the default > set of tests that are run before committing. Since the nightly > regressions use this same script, this will also be the new > nightly regression behavior. > > Test-only regressions can still be done by setting --compile=''. > Compile-only regressions can be done by setting --test=''. > > > Diffs > ----- > > util/regress a9d06c894afe > > Diff: http://reviews.m5sim.org/r/649/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
