> > I looked at it and it is similar, but it's different enough that they can't > be interchanged. My functions all allow passing a string in as standard input > and return the error code, but readCommand doesn't. I could extend it to take > an input string, but it's not clear how to return the output and the error > code without changing all the call sites and complicating all the code that's > working fine now without it. readCommand doesn't allow printing the command > before it's run so I'd have to add a wrapper to handle that, and it doesn't > handle adding 'sudo'. I think tying in readCommand would actually make > everything bigger and more complicated because it's not quite what I need and > I'd have to add a bunch of wrappers. Also wrapping all the possible > variations of Popen people might need (not that that's what you're saying, > but it heads that way) is probably also counter productive because at that > point you might as well just use Popen directly. > > I totally agree. If it doesn't work, it doesn't work. Is it something reusable that should go in m5.util?
Nate _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
