That sounds reasonable. With too many reviews it gets harder to get to
all of them, and some obscure things may languish with no reviews
because only one person is comfortable with that code. Reviews are
generally a really good thing but they have some overhead. If we don't
get more benefit than that threshold, they aren't worth it in that case.
Gabe
Quoting nathan binkert <n...@binkert.org>:
Hi Everyone,
We don't have an official policy on code reviews, but I think we're
being a bit pedantic with them. While I definitely want us to err on
the side of having code review is the author has any doubt, I think it
is completely unnecessary to have reviews on things like changing
comments and text in strings. Similarly, obvious bug fixes (though
this is one of those subjective things that the author has to
consider) need not be reviewed.
What do you all think? What is our policy? Am I crazy? Should we
review everything?
Nate
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
