> On 2011-05-02 16:54:31, Gabe Black wrote: > > Generally speaking, I'd like to see us move towards using the same > > traceflags across ISAs and CPUs. If I'm using the SimpleCPU, being able to > > select DPRINTFs specific to the SimpleCPU isn't that useful. I'm not going > > to hit an O3 DPRINTF whether I have them turned on or not. Instead, it > > might be better to, say, use a Fetch traceflag to go with Fetch actions. > > Then you can be more specific and have to remember fewer particulars of the > > thing you're working with. You could have a compound traceflag called > > SimpleCPU (or just CPU?) which would turn on all the basics. It might get a > > little tricky if you have multiple CPU types and wanted to turn on only the > > ones in the SimpleCPU, but I expect that to be relatively uncommon. > > > > I'd encourage you to think about changing things around like this, but I > > understand it expands the scope of what you were trying to do > > significantly. I'm ok if you leave it as is.
I'm on board with having traceflags mean the same across CPU models. The answer to this is to have compound trace flags be able to contain other compound trace flags. (Nate says his new changes will allow this, so cross your fingers!) If you do this, then that means we can define the Fetch traceflag to mean: Fetch: SimpleCPUFetch,O3Fetch,InOrderFetch and then the CPU models can define what are the relevant flags appropriately. - Korey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/671/#review1184 ----------------------------------------------------------- On 2011-05-02 15:41:50, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/671/ > ----------------------------------------------------------- > > (Updated 2011-05-02 15:41:50) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > CPU: Add some useful debug message to the timing simple cpu. > > > Diffs > ----- > > src/cpu/simple/timing.cc 3f49ed206f46 > > Diff: http://reviews.m5sim.org/r/671/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
