> On 2011-05-04 21:00:53, Gabe Black wrote: > > src/cpu/exetrace.cc, line 65 > > <http://reviews.m5sim.org/r/678/diff/1/?file=12419#file12419line65> > > > > Maybe put these ifs together with an or? It's not hugely better since > > the body is so short, but it's something to consider.
It ends up being an extra line and no less clear, but it can be done. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/678/#review1207 ----------------------------------------------------------- On 2011-05-04 18:42:30, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/678/ > ----------------------------------------------------------- > > (Updated 2011-05-04 18:42:30) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Trace: Allow printing ASIDs and selectively tracing based on user/kernel code. > > Debug flags are ExecUser, ExecKernel, and ExecAsid. ExecUser and > ExecKernel are set by default when Exec is specified. Use minus > sign with ExecUser or ExecKernel to remove user or kernel tracing > respectively. > > > Diffs > ----- > > src/arch/alpha/utility.hh 5a9a639ce16f > src/arch/alpha/utility.cc 5a9a639ce16f > src/arch/arm/utility.hh 5a9a639ce16f > src/arch/mips/utility.hh 5a9a639ce16f > src/arch/power/utility.hh 5a9a639ce16f > src/arch/sparc/utility.hh 5a9a639ce16f > src/arch/x86/utility.hh 5a9a639ce16f > src/cpu/SConscript 5a9a639ce16f > src/cpu/exetrace.cc 5a9a639ce16f > > Diff: http://reviews.m5sim.org/r/678/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
