----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/690/#review1222 -----------------------------------------------------------
src/base/stats/text.hh <http://reviews.m5sim.org/r/690/#comment1686> What do begin and end() do? src/base/stats/text.cc <http://reviews.m5sim.org/r/690/#comment1687> Should this still be printed for here? Or rather, what is the point of printing some text here and all the stats from python? src/base/stats/text.cc <http://reviews.m5sim.org/r/690/#comment1688> Same question here? Why not just create this in python? src/python/m5/stats/__init__.py <http://reviews.m5sim.org/r/690/#comment1689> In what cases does dump() get called twice? - Ali On 2011-05-10 06:08:36, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/690/ > ----------------------------------------------------------- > > (Updated 2011-05-10 06:08:36) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > stats: move code that loops over all stats into python > > > Diffs > ----- > > src/base/SConscript 44f8c2507d85 > src/base/statistics.hh 44f8c2507d85 > src/base/statistics.cc 44f8c2507d85 > src/base/stats/info.hh 44f8c2507d85 > src/base/stats/mysql.hh 44f8c2507d85 > src/base/stats/mysql.cc 44f8c2507d85 > src/base/stats/output.hh 44f8c2507d85 > src/base/stats/output.cc 44f8c2507d85 > src/base/stats/text.hh 44f8c2507d85 > src/base/stats/text.cc 44f8c2507d85 > src/base/stats/visit.hh 44f8c2507d85 > src/base/stats/visit.cc 44f8c2507d85 > src/python/m5/simulate.py 44f8c2507d85 > src/python/m5/stats/__init__.py PRE-CREATION > src/python/swig/stats.i 44f8c2507d85 > > Diff: http://reviews.m5sim.org/r/690/diff > > > Testing > ------- > > quick regressions pass (though most recently run with review 689 and 691) > > > Thanks, > > Nathan > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
