> On 2011-05-09 16:58:52, Tushar Krishna wrote: > > Hey Brad, > > We will need some way for the total number of virtual networks declared in > > these protocol files to be reflected in one of the network simobject.py > > files, so that the config.ini file prints out the correct value for virtual > > networks. Currently it prints out the default value of 10 from Network.py, > > though the actual number of active vnets is lower. > > Just to let you know while you review this patch since the change for that > > might be related ... > > > > Thanks
This is certainly the easiest way to provide this capability and I'm fine with checking it in. However, as I mentioned to you yesterday, this is just a short-term solution until we figure out how to move these virtual channel details into the protocol python files. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/686/#review1218 ----------------------------------------------------------- On 2011-05-08 21:09:50, Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/686/ > ----------------------------------------------------------- > > (Updated 2011-05-08 21:09:50) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, and Brad Beckmann. > > > Summary > ------- > > slicc: added vnet_type field to identify response vnets from others > > Identifying response vnets versus other vnets will allow garnet to > determine which vnets will carry data packets, and which will carry > ctrl packets, and use appropriate buffer sizes (since data packets are larger > than ctrl packets). This in turn allows the orion power model to accurately > estimate buffer power. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-L1cache.sm db269e704d07 > src/mem/protocol/MESI_CMP_directory-L2cache.sm db269e704d07 > src/mem/protocol/MESI_CMP_directory-dir.sm db269e704d07 > src/mem/protocol/MESI_CMP_directory-dma.sm db269e704d07 > src/mem/protocol/MOESI_CMP_directory-L1cache.sm db269e704d07 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm db269e704d07 > src/mem/protocol/MOESI_CMP_directory-dir.sm db269e704d07 > src/mem/protocol/MOESI_CMP_directory-dma.sm db269e704d07 > src/mem/protocol/MOESI_CMP_token-L1cache.sm db269e704d07 > src/mem/protocol/MOESI_CMP_token-L2cache.sm db269e704d07 > src/mem/protocol/MOESI_CMP_token-dir.sm db269e704d07 > src/mem/protocol/MOESI_CMP_token-dma.sm db269e704d07 > src/mem/protocol/MOESI_hammer-cache.sm db269e704d07 > src/mem/protocol/MOESI_hammer-dir.sm db269e704d07 > src/mem/protocol/MOESI_hammer-dma.sm db269e704d07 > src/mem/protocol/Network_test-cache.sm db269e704d07 > src/mem/protocol/Network_test-dir.sm db269e704d07 > src/mem/ruby/network/Network.hh db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc db269e704d07 > src/mem/ruby/network/simple/SimpleNetwork.hh db269e704d07 > src/mem/ruby/network/simple/SimpleNetwork.cc db269e704d07 > src/mem/slicc/symbols/StateMachine.py db269e704d07 > > Diff: http://reviews.m5sim.org/r/686/diff > > > Testing > ------- > > > Thanks, > > Tushar > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
