----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/688/#review1224 -----------------------------------------------------------
Ship it! Just when I was getting use to refering to virtual channels as message classes, you're changing the name back to vnets. :) This looks good to me. - Brad On 2011-05-08 23:08:23, Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/688/ > ----------------------------------------------------------- > > (Updated 2011-05-08 23:08:23) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, and Brad Beckmann. > > > Summary > ------- > > garnet: rename and rearrange config parameters > > Renamed (message) class to vnet for consistency with rest of ruby. > Moved some parameters specific to fixed/flexible garnet networks into their > corresponding py files. > > > Diffs > ----- > > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh db269e704d07 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc db269e704d07 > src/mem/ruby/network/garnet/BaseGarnetNetwork.py db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.py db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetRouter_d.py db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc db269e704d07 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.py db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.py db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetRouter.py db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc db269e704d07 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc db269e704d07 > > Diff: http://reviews.m5sim.org/r/688/diff > > > Testing > ------- > > > Thanks, > > Tushar > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
