----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/#review1232 -----------------------------------------------------------
Ship it! Hi Nilay, I see no reason why this would not work with our protocols. Thanks for checking. - Lisa On 2011-05-06 15:52:00, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/684/ > ----------------------------------------------------------- > > (Updated 2011-05-06 15:52:00) > > > Review request for Default. > > > Summary > ------- > > Ruby: Correctly set access permissions for directory entries > The access permissions for the directory entries are not being set correctly. > This is because pointers are not used for handling directory entries. > function. The setState() function will once again set the permissions as well. > But it would make use of the State_to_permission() function, instead of doing > the analysis it used to do earlier. The changePermission() function provided > by the AbstractEntry and AbstractCacheEntry classes has been exposed to SLICC > code once again. The set_permission() functionality has been removed. > > I have done this only for the MESI protocol so far. Once we build a consensus > one the changes, I will make changes to other protocols as well. > > As far as testing is concerned, the protocol compiles and clears 10000 loads. > I did not test any more than that. > > A point that I wanted to raise for discussion: I think we should pull State > enum and the accompanying functions into the Machine it self. Brad, what do > you think? > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-L1cache.sm 3c628a51f6e1 > src/mem/protocol/MESI_CMP_directory-L2cache.sm 3c628a51f6e1 > src/mem/protocol/MESI_CMP_directory-dir.sm 3c628a51f6e1 > src/mem/protocol/RubySlicc_Types.sm 3c628a51f6e1 > src/mem/slicc/ast/MethodCallExprAST.py 3c628a51f6e1 > src/mem/slicc/symbols/StateMachine.py 3c628a51f6e1 > > Diff: http://reviews.m5sim.org/r/684/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
