----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/705/#review1239 -----------------------------------------------------------
Ship it! Because of how the macroops/microops are structure this is technically not necessary for functional correctness, but it's probably necessary for determinism and to pacify gcc. It's also not a bad idea in case somebody reuses these microops in a way I didn't intend when I wrote them. - Gabe On 2011-05-17 11:48:15, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/705/ > ----------------------------------------------------------- > > (Updated 2011-05-17 11:48:15) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > gcc: fix an uninitialized variable warning from G++ 4.5 > > > Diffs > ----- > > src/arch/arm/isa/insts/macromem.isa fb0e525008c5 > > Diff: http://reviews.m5sim.org/r/705/diff > > > Testing > ------- > > > Thanks, > > Nathan > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
