> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/AddressProfiler.cc, line 235 > > <http://reviews.m5sim.org/r/704/diff/1/?file=12593#file12593line235> > > > > .name should really have name() as part of the name. Is the > > AddressProfiler not a SimObject() ? > > Derek Hower wrote: > I don't think it is.
Can I suggest that you create a name() function anyway and have some way to set the name variable? This will facilitate conversion to a SimObject in the future and make things like DPRINTF work better (DPRINTF requires name()) - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/704/#review1237 ----------------------------------------------------------- On 2011-05-16 15:06:16, Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/704/ > ----------------------------------------------------------- > > (Updated 2011-05-16 15:06:16) > > > Review request for Default, Nathan Binkert, Korey Sewell, and Brad Beckmann. > > > Summary > ------- > > This patch contains changes to convert Ruby's stat handling to the M5-style > Stat class. The ultimate goal is to remove Profiler entirely, though this > patch only represents a (significant) step towards that goal. Some stats > remain in the Profiler, notably those that do not have an obvious object to > hold them (like Address Profiler) or those that I'm not sure what they do > (e.g., *wCC*). Also, this patch does not contain a Garnet stats conversion > (though the simple network is converted). > > > Diffs > ----- > > src/mem/ruby/network/simple/SimpleNetwork.hh UNKNOWN > src/mem/ruby/network/simple/SimpleNetwork.cc UNKNOWN > src/mem/ruby/network/simple/Throttle.hh UNKNOWN > src/mem/ruby/network/simple/Throttle.cc UNKNOWN > src/mem/ruby/profiler/AddressProfiler.hh UNKNOWN > src/mem/ruby/profiler/AddressProfiler.cc UNKNOWN > src/mem/ruby/profiler/CacheProfiler.hh UNKNOWN > src/mem/ruby/profiler/CacheProfiler.cc UNKNOWN > src/mem/ruby/profiler/MemCntrlProfiler.hh UNKNOWN > src/mem/ruby/profiler/MemCntrlProfiler.cc UNKNOWN > src/mem/ruby/profiler/Profiler.hh UNKNOWN > src/mem/ruby/profiler/Profiler.cc UNKNOWN > src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.hh UNKNOWN > src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc UNKNOWN > src/mem/ruby/system/CacheMemory.hh UNKNOWN > src/mem/ruby/system/MemoryControl.hh UNKNOWN > src/mem/ruby/system/Sequencer.hh UNKNOWN > src/mem/ruby/system/Sequencer.cc UNKNOWN > src/mem/ruby/system/System.cc UNKNOWN > src/mem/slicc/symbols/StateMachine.py UNKNOWN > > Diff: http://reviews.m5sim.org/r/704/diff > > > Testing > ------- > > > Thanks, > > Derek > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev